[webkit-reviews] review granted: [Bug 216264] Having an iframe as a descendent node shouldn't require ElementRareData : [Attachment 408279] Fixed tests

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 216264: Having an iframe as a descendent node shouldn't require
ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=216264

Attachment 408279: Fixed tests

https://bugs.webkit.org/attachment.cgi?id=408279&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 408279
  --> https://bugs.webkit.org/attachment.cgi?id=408279
Fixed tests

View in context: https://bugs.webkit.org/attachment.cgi?id=408279&action=review

> Source/WebCore/ChangeLog:8
> +	   Store the number of connected frames in the descendent nodes
direclty in Node using CompactUniquePtrTuple

typo: "directly"

> Source/WebCore/dom/Node.h:540
> +	   IsEditingText = 1 << 15, // Text
> +	   HasFocusWithin = 1 << 16, // Element

Can’t these share a bit, since Text and Element are mutually exclusive?

> Source/WebCore/dom/Node.h:576
> +	   uint16_t connectedSubframeCount : 10; // Must fit
Page::maxNumberOfFrames.

Can we use a static_assert to make this more than just a comment?

> Source/WebCore/dom/NodeRareData.cpp:39
> +    uint32_t m_tabInex;

Typo here: m_tabIndex.

Maybe this "same size" struct should not bother using "m_" prefixes?