[webkit-reviews] review granted: [Bug 216279] Fix precision issues in AudioParamTimeline when event times are very close : [Attachment 408250] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216279: Fix precision issues in AudioParamTimeline when event times are
very close
https://bugs.webkit.org/show_bug.cgi?id=216279

Attachment 408250: Patch

https://bugs.webkit.org/attachment.cgi?id=408250&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408250
  --> https://bugs.webkit.org/attachment.cgi?id=408250
Patch

I see that the code involves a lot of floating point division. Last time I
checked, I believe floating point multiplication was significantly faster.
Perhaps we can make some of this division be multiplication by calculating a
reciprocal or by reorganizing expressions. Or perhaps this kind of
micro-optimization thinking is not relevant to this code.

r=me assuming the tests pass