[webkit-reviews] review granted: [Bug 216209] iOS: <attachment>'s QuickLook thumbnails can appear squished : [Attachment 408240] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 10:38:47 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 216209: iOS: <attachment>'s QuickLook thumbnails can appear squished
https://bugs.webkit.org/show_bug.cgi?id=216209

Attachment 408240: Patch

https://bugs.webkit.org/attachment.cgi?id=408240&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 408240
  --> https://bugs.webkit.org/attachment.cgi?id=408240
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408240&action=review

>
LayoutTests/fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html:23
> +    let intervalID = setInterval(function () {

Nit - maybe you could use `shouldBecomeDifferent` here instead of
`setInterval`?


More information about the webkit-reviews mailing list