[webkit-reviews] review granted: [Bug 216199] Remove storage WorkQueue in NetworkProcess : [Attachment 408045] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 216199: Remove storage WorkQueue in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=216199

Attachment 408045: Patch

https://bugs.webkit.org/attachment.cgi?id=408045&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 408045
  --> https://bugs.webkit.org/attachment.cgi?id=408045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408045&action=review

> Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:544
> +void IDBServer::collectOriginsForVersion(const String& versionPath,
HashSet<WebCore::SecurityOriginData>& securityOrigins) const

Can we make it a static function instead of a method?

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:69
> +	   LockHolder locker(m_server->lock());

Shouldn't we lock in getOrigins instead?

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1560
> +		   callbackAggregator->m_websiteData.entries.append({
origins.takeAny(), WebsiteDataType::IndexedDBDatabases, 0 });

It seems we could return a Vector.
We added an optimisation for Vector::isolatedCopy() const && which would be
nice as well to use.