[webkit-reviews] review granted: [Bug 215707] [iOS] attachmentActionFont() Needs to use kCTFontSymbolicTrait: @(kCTFontTraitTightLeading | kCTFontTraitEmphasized) to get the short emphasized footnote font : [Attachment 408155] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 215707: [iOS] attachmentActionFont() Needs to use kCTFontSymbolicTrait:
@(kCTFontTraitTightLeading | kCTFontTraitEmphasized) to get the short
emphasized footnote font
https://bugs.webkit.org/show_bug.cgi?id=215707

Attachment 408155: Patch

https://bugs.webkit.org/attachment.cgi?id=408155&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 408155
  --> https://bugs.webkit.org/attachment.cgi?id=408155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408155&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1404
> +    CFStringRef style = kCTUIFontTextStyleFootnote;
> +    CFStringRef size = RenderThemeIOS::singleton().contentSizeCategory();
> +    CFDictionaryRef attributes = static_cast<CFDictionaryRef>(@{
(id)kCTFontTraitsAttribute: @{ (id)kCTFontSymbolicTrait:
@(kCTFontTraitTightLeading | kCTFontTraitEmphasized) } });

I would have used auto for all three of these.