[webkit-reviews] review granted: [Bug 215685] CTFontGetPhysicalSymbolicTraits() is faster than CTFontCopyPhysicalFont()/CTFontGetSymbolicTraits() : [Attachment 408142] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 215685: CTFontGetPhysicalSymbolicTraits() is faster than
CTFontCopyPhysicalFont()/CTFontGetSymbolicTraits()
https://bugs.webkit.org/show_bug.cgi?id=215685

Attachment 408142: Patch

https://bugs.webkit.org/attachment.cgi?id=408142&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 408142
  --> https://bugs.webkit.org/attachment.cgi?id=408142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408142&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:858
> +	       RetainPtr<CTFontRef> fontForSynthesisComputation = font;

auto fontForSynthesisComputation = retainPtr(font);

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h:57
> +enum class ShouldComputePhysicalTraits : uint8_t {
> +    Yes,
> +    No
> +};

I suggest bool instead of uint8_t, No before Yes, and putting this on a single
line instead of vertically on 4 lines.