[webkit-reviews] review granted: [Bug 216230] ConvolverNode incorrectly outputs silence because m_reverb is null : [Attachment 408133] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 6 14:32:33 PDT 2020
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216230: ConvolverNode incorrectly outputs silence because m_reverb is null
https://bugs.webkit.org/show_bug.cgi?id=216230
Attachment 408133: Patch
https://bugs.webkit.org/attachment.cgi?id=408133&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408133
--> https://bugs.webkit.org/attachment.cgi?id=408133
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=408133&action=review
> Source/WebCore/Modules/webaudio/ConvolverNode.h:-63
> - void initialize() final;
> - void uninitialize() final;
Can we refactor to get rid of these across the board? Are they valuable?
More information about the webkit-reviews
mailing list