[webkit-reviews] review granted: [Bug 216223] [MotionMark - Multiply] Web process spends ~1% of total samples in PropertyCascade::resolveDirectionAndWritingMode : [Attachment 408131] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 216223: [MotionMark - Multiply] Web process spends ~1% of total samples in
PropertyCascade::resolveDirectionAndWritingMode
https://bugs.webkit.org/show_bug.cgi?id=216223

Attachment 408131: Patch

https://bugs.webkit.org/attachment.cgi?id=408131&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 408131
  --> https://bugs.webkit.org/attachment.cgi?id=408131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408131&action=review

> Source/WebCore/ChangeLog:39
> +	   Add a new `bool` member to keep track of whether or not the CSS
direction has not yet been resolved. Note that
> +	   since this member variable fits within the padding after `Direction
m_direction;`, this class is still the same
> +	   size.

Would Optional have been too inefficient to use here?