[webkit-reviews] review granted: [Bug 216225] Make CompactUniquePtrTuple actually work with subclassing and custom deleter : [Attachment 408121] Fixes the bugs

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 216225: Make CompactUniquePtrTuple actually work with subclassing and
custom deleter
https://bugs.webkit.org/show_bug.cgi?id=216225

Attachment 408121: Fixes the bugs

https://bugs.webkit.org/attachment.cgi?id=408121&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408121
  --> https://bugs.webkit.org/attachment.cgi?id=408121
Fixes the bugs

View in context: https://bugs.webkit.org/attachment.cgi?id=408121&action=review

> Source/WTF/wtf/CompactUniquePtrTuple.h:69
> +	   CompactUniquePtrTuple<T, Type, Deleter> moved { WTFMove(other) };

Here inside a member we should not need to repeat the template arguments, so
although it can’t use auto, it can be like this:

    CompactUniquePtrTuple moved { WTFMove(other) };

> Source/WTF/wtf/CompactUniquePtrTuple.h:118
> +    template <typename U, typename Y, typename D> friend class
CompactUniquePtrTuple;

No need for the U/Y/D here. Can just be "typename, typename, typename".