[webkit-reviews] review granted: [Bug 216221] [LFC][IFC] LineBox should contain all inline boxes : [Attachment 408124] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 216221: [LFC][IFC] LineBox should contain all inline boxes
https://bugs.webkit.org/show_bug.cgi?id=216221

Attachment 408124: Patch

https://bugs.webkit.org/attachment.cgi?id=408124&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 408124
  --> https://bugs.webkit.org/attachment.cgi?id=408124
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408124&action=review

> Source/WebCore/ChangeLog:18
> +	   In this patch we decouple the line box and the line.
> +	   LineBox:
> +	   - fully contains all the inline boxes, both horizontally and
vertically.
> +	   - has only width and height geometry
> +	   - height is not constrained by the line-height property
> +	   - does not have the concept of overflow.
> +
> +	   Line:
> +	   - contains the LineBox, but the LineBox can overflow the line, both
horizontally and vertically.
> +	   - has position relative to the root block container.
> +

Could you clarify in the ChangeLog how this decoupling maps to the code changes
in the patch?

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:51
> +// | ----------------------------------|--------------|---------- Root
Inline Box
> +// ||   _____    ___      ___	  |		 |
> +// ||  |	   /   \    /	\	  |  Inline Box  |
> +// ||  |_____  |	|  |	 |	  |		 |    ascent
> +// ||  |	  |	|  |	 |	  |		 |
> +// ||__|________\___/____\___/_________|______________|_______
alignment_baseline

Could you make this FOO larger? I can barely see it.