[webkit-reviews] review granted: [Bug 216181] [WebXR] Implement XRSession end event : [Attachment 407984] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 216181: [WebXR] Implement XRSession end event
https://bugs.webkit.org/show_bug.cgi?id=216181

Attachment 407984: Patch

https://bugs.webkit.org/attachment.cgi?id=407984&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 407984
  --> https://bugs.webkit.org/attachment.cgi?id=407984
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407984&action=review

> Source/WebCore/Modules/webxr/XRSessionEvent.h:39
> +    static Ref<XRSessionEvent> create(const AtomString&,
RefPtr<WebXRSession>&&);

In new code I suggest we start using the Init structures in our C++ code
instead of having multiple constructors and create functions in all our event
classes. I tried his and it seemed to come out pretty good but the patch to do
it across the board is huge.