[webkit-reviews] review granted: [Bug 216194] [WebIDL] Realign our IDL extended attribute names with those specified in WebIDL : [Attachment 408087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 5 09:02:25 PDT 2020


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 216194: [WebIDL] Realign our IDL extended attribute names with those
specified in WebIDL
https://bugs.webkit.org/show_bug.cgi?id=216194

Attachment 408087: Patch

https://bugs.webkit.org/attachment.cgi?id=408087&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 408087
  --> https://bugs.webkit.org/attachment.cgi?id=408087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408087&action=review

Given the “legacy” in LegacyNoInterfaceObject, it’s surprising that it’s so
often needed for correct behavior even in relatively new features. Perhaps they
erred when naming it?

r=me assuming great EWS results

> Source/WebCore/bindings/js/JSDOMAbstractOperations.h:35
> +enum class LegacyOverrideBuiltIns {

Make this a one-liner? Vertical form not great for a Yes/No.


More information about the webkit-reviews mailing list