[webkit-reviews] review granted: [Bug 215689] [Cocoa] Unify implementation of custom font name aliases between all Cocoa platforms : [Attachment 406918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 5 08:54:11 PDT 2020


Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 215689: [Cocoa] Unify implementation of custom font name aliases between
all Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=215689

Attachment 406918: Patch

https://bugs.webkit.org/attachment.cgi?id=406918&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406918
  --> https://bugs.webkit.org/attachment.cgi?id=406918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406918&action=review

Nice improvement.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311
> +	   RetainPtr<CFNumberRef> numberSpacingNumber =
adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType,
&numberSpacingType));

auto

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1312
> +	   RetainPtr<CFNumberRef> monospacedNumbersNumber =
adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType,
&monospacedNumbersSelector));

auto

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1313
> +	   RetainPtr<CTFontDescriptorRef> systemFontDescriptor =
adoptCF(CTFontDescriptorCreateForUIType(kCTFontUIFontSystem, size, nullptr));

auto

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1314
> +	   RetainPtr<CTFontDescriptorRef> monospaceFontDescriptor =
adoptCF(CTFontDescriptorCreateCopyWithFeature(systemFontDescriptor.get(),
numberSpacingNumber.get(), monospacedNumbersNumber.get()));

auto


More information about the webkit-reviews mailing list