[webkit-reviews] review granted: [Bug 216202] TextDecoder should properly handle streams : [Attachment 408067] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 5 08:38:08 PDT 2020

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 216202: TextDecoder should properly handle streams

Attachment 408067: Patch


--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 408067
  --> https://bugs.webkit.org/attachment.cgi?id=408067

View in context: https://bugs.webkit.org/attachment.cgi?id=408067&action=review

Excellent. This is exactly how the TextCodec class was designed to be used.

> Source/WebCore/dom/TextDecoder.h:54
> +    ~TextDecoder();

We typically put this before other member functions. Arbitrary, but it’s
atypical to put it at the end of the public section.

> Source/WebCore/dom/TextDecoder.h:64
> +    std::unique_ptr<TextCodec> m_textCodec;

I would have named this just m_codec.

More information about the webkit-reviews mailing list