[webkit-reviews] review granted: [Bug 216193] [JSC] Align legacy Intl constructor behavior to spec : [Attachment 408058] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 216193: [JSC] Align legacy Intl constructor behavior to spec
https://bugs.webkit.org/show_bug.cgi?id=216193

Attachment 408058: Patch

https://bugs.webkit.org/attachment.cgi?id=408058&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 408058
  --> https://bugs.webkit.org/attachment.cgi?id=408058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408058&action=review

> Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp:114
> +    auto* dtf = IntlDateTimeFormat::unwrapForOldFunctions(globalObject,
callFrame->thisValue());

auto format

> Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp:146
> +    auto* dateTimeFormat = jsDynamicCast<IntlDateTimeFormat*>(vm,
callFrame->thisValue());

I’d like auto format here too

> Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp:117
> +    auto* nf = IntlNumberFormat::unwrapForOldFunctions(globalObject,
callFrame->thisValue());

auto format