[webkit-reviews] review denied: [Bug 216202] Allow TextCodec::decode to properly handle streams : [Attachment 408046] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 19:55:16 PDT 2020

Alex Christensen <achristensen at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 216202: Allow TextCodec::decode to properly handle streams

Attachment 408046: Patch


--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 408046
  --> https://bugs.webkit.org/attachment.cgi?id=408046

View in context: https://bugs.webkit.org/attachment.cgi?id=408046&action=review

>> Source/WebCore/ChangeLog:8
>> +	    In order to properly handle cases like a stream breaking in the
middle of a surrogate pair
> Doesn't text decoding already properly handle such cases when decoding
content as it comes from the network?

That uses TextResourceDecoder, which stores a std::unique_ptr<TextCodec> which
keeps state instead of keeping a buffer like TextDecoder currently does.  While
this approach passes all existing web platform tests, it is incorrect.	I need
to keep a std::unique_ptr<TextCodec> instead of a buffer, and I should probably
add a test that fails with this implementation and passes with a correct
implementation.  the only decoding failures in the existing tests are at the
end of a stream block.

More information about the webkit-reviews mailing list