[webkit-reviews] review granted: [Bug 203698] [EWS] Layout testers can go in an infinite RETRY loop when there are 30+ failures on trunk : [Attachment 384207] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 203698: [EWS] Layout testers can go in an infinite RETRY loop when there
are 30+ failures on trunk
https://bugs.webkit.org/show_bug.cgi?id=203698

Attachment 384207: Patch

https://bugs.webkit.org/attachment.cgi?id=384207&action=review




--- Comment #8 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 384207
  --> https://bugs.webkit.org/attachment.cgi?id=384207
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384207&action=review

>>> Tools/BuildSlaveSupport/ews-build/config.json:349
>>> +	   "triggered_by": ["ios-13-sim-build-ews"],
>> 
>> This makes sense to me, but I don't understand why this isn't already here,
since ios-simulator-13 has been triggered by ios-13-sim-build-ews for months.
> 
> This 'triggered_by' key is used just for passing information. I wasn't able
to dynamically extract this information (about who triggered current build)
using buildbot. So I am passing this information in a static manner. This
information is used by tester build, to trigger back the builder.
> 
> Yes, iOS-13-Simulator-WK2-Tests-EWS is triggered by
iOS-13-Simulator-Build-EWS using the 'triggers' key.

That's unfortunate, but does answer my question!