[webkit-reviews] review granted: [Bug 215956] CoreImage Implementation of CSS Filters invert(), opacity(), brightness(), contrast() : [Attachment 408006] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted guowei_yang at apple.com's request for
review:
Bug 215956: CoreImage Implementation of CSS Filters invert(), opacity(),
brightness(), contrast()
https://bugs.webkit.org/show_bug.cgi?id=215956

Attachment 408006: Patch

https://bugs.webkit.org/attachment.cgi?id=408006&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 408006
  --> https://bugs.webkit.org/attachment.cgi?id=408006
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408006&action=review

>
Source/WebCore/platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:68
> +	   return isNullOrLinear(effect.redFunction()) &&
isNullOrLinear(effect.greenFunction())
> +	       && isNullOrLinear(effect.blueFunction()) &&
isNullOrLinear(effect.alphaFunction());

This is indented too much.

>
Source/WebCore/platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:241
> +    CIFilter* filter = [CIFilter filterWithName:@"CIColorPolynomial"];

I suggest auto here.