[webkit-reviews] review granted: [Bug 215949] [ews] Notify bot watchers about pre-existing and flaky test failures for API tests : [Attachment 407957] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 215949: [ews] Notify bot watchers about pre-existing and flaky test
failures for API tests
https://bugs.webkit.org/show_bug.cgi?id=215949

Attachment 407957: Patch

https://bugs.webkit.org/attachment.cgi?id=407957&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 407957
  --> https://bugs.webkit.org/attachment.cgi?id=407957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407957&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2606
> +    def send_email_for_flaky_failure(self, test_name):

I'm find with this as-is, but it does seem like we're duplicating quite a bit
of code for layout test emails.

Seems like we might want a base "AnalyzeTestResults" step with a
"send_email_for_flaky_failure(self, test_name):" function that pulls from a
"suite" variable