[webkit-reviews] review granted: [Bug 216012] Webpages flash when switching between windows : [Attachment 407817] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 216012: Webpages flash when switching between windows
https://bugs.webkit.org/show_bug.cgi?id=216012

Attachment 407817: Patch

https://bugs.webkit.org/attachment.cgi?id=407817&action=review




--- Comment #34 from Tim Horton <thorton at apple.com> ---
Comment on attachment 407817
  --> https://bugs.webkit.org/attachment.cgi?id=407817
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407817&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:494
> +    bool hasScheduledOnObserver =
m_activityStateChangeDispatcher->isScheduled();

"on"?

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:520
> +    if (![CATransaction currentState]) {

Both of the places you check this should have comments, since it's very very
weird.

Maybe we should just adjust the tests instead? Is this a state you can ever get
to in "reality"?