[webkit-reviews] review granted: [Bug 176215] Letter-spacing should disable ligatures : [Attachment 407951] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 02:50:58 PDT 2020

Antti Koivisto <koivisto at iki.fi> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 176215: Letter-spacing should disable ligatures

Attachment 407951: Patch


--- Comment #24 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 407951
  --> https://bugs.webkit.org/attachment.cgi?id=407951

View in context: https://bugs.webkit.org/attachment.cgi?id=407951&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:536
> +// FIXME: This function is 180 lines long. We should factor it into smaller

This seems bit unnecessary. It will also easily become a lie when someone adds
more lines and forgets to update the number.

More information about the webkit-reviews mailing list