[webkit-reviews] review granted: [Bug 215852] Web Inspector fails to preview response from XHR requests : [Attachment 407915] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 3 17:04:22 PDT 2020
Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 215852: Web Inspector fails to preview response from XHR requests
https://bugs.webkit.org/show_bug.cgi?id=215852
Attachment 407915: Patch
https://bugs.webkit.org/attachment.cgi?id=407915&action=review
--- Comment #28 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 407915
--> https://bugs.webkit.org/attachment.cgi?id=407915
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=407915&action=review
r=me, nice work!
> Source/WebInspectorUI/ChangeLog:13
> + * UserInterface/Models/Resource.js: More consistant error handling
model - previously some paths rejected on
NIT: double space
> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:552
> + resourceResponse->setString("mimeType",
previousResourceData->mimeType());
missing `_s`
> Source/WebInspectorUI/UserInterface/Models/Resource.js:1196
> + sourceCode: this
Style: please include a trailing comma for any multi-line objects/arrays
More information about the webkit-reviews
mailing list