[webkit-reviews] review granted: [Bug 216132] Make AudioParam.cancelScheduledValues() standards compliant : [Attachment 407895] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216132: Make AudioParam.cancelScheduledValues() standards compliant
https://bugs.webkit.org/show_bug.cgi?id=216132

Attachment 407895: Patch

https://bugs.webkit.org/attachment.cgi?id=407895&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 407895
  --> https://bugs.webkit.org/attachment.cgi?id=407895
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407895&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:165
> +	   if (eventTime >= cancelTime || ((m_events[i].type() ==
ParamEvent::SetValueCurve)
> +	       && eventTime <= cancelTime && (eventTime +
m_events[i].duration() > cancelTime))) {

This condition clause might read more easily as a helper lambda called as
"isAfter(m_events[I], cancelTime)".