[webkit-reviews] review granted: [Bug 216133] Web Inspector: Timelines: record button disappears when UI is narrow : [Attachment 407896] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 216133: Web Inspector: Timelines: record button disappears when UI is
narrow
https://bugs.webkit.org/show_bug.cgi?id=216133

Attachment 407896: Patch

https://bugs.webkit.org/attachment.cgi?id=407896&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 407896
  --> https://bugs.webkit.org/attachment.cgi?id=407896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407896&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:49
> +	   this._recordButton.visibilityPriority =
WI.NavigationItem.VisibilityPriority.High;

we should also do this to `_continueButton`, as it's shown instead of
`_recordButton` when ⌥ is pressed and the active recording will auto-stop
(`WI.TimelineTabContentView.prototype._updateNavigationBarButtons`)