[webkit-reviews] review granted: [Bug 215794] Web Inspector: allow special JavaScript breakpoints to be configured : [Attachment 407873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 09:32:52 PDT 2020


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 215794: Web Inspector: allow special JavaScript breakpoints to be
configured
https://bugs.webkit.org/show_bug.cgi?id=215794

Attachment 407873: Patch

https://bugs.webkit.org/attachment.cgi?id=407873&action=review




--- Comment #9 from Brian Burg <bburg at apple.com> ---
Comment on attachment 407873
  --> https://bugs.webkit.org/attachment.cgi?id=407873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407873&action=review

r=me

> Source/JavaScriptCore/debugger/Debugger.h:75
> +    class TemporarilyDisableExceptionBreakpoints {

Nit: can't this be defined entirely in the .cpp file? Is it used outside this
class?


More information about the webkit-reviews mailing list