[webkit-reviews] review granted: [Bug 216085] WebCore::DOMTimerFireState constructor fails to initialize m_initialDOMTreeVersion, m_previous on worker threads : [Attachment 407780] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 216085: WebCore::DOMTimerFireState constructor fails to initialize
m_initialDOMTreeVersion, m_previous on worker threads
https://bugs.webkit.org/show_bug.cgi?id=216085

Attachment 407780: Patch v1

https://bugs.webkit.org/attachment.cgi?id=407780&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 407780
  --> https://bugs.webkit.org/attachment.cgi?id=407780
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=407780&action=review

> Source/WebCore/page/DOMTimer.cpp:100
>      bool m_contextIsDocument;

Why not initialize this to false, too? I know it’s not necessary, but seems
worth doing.

Keep in mind that those other two are never used when m_contextIsDocument is
false, so all of this is just "defensive programming".