[webkit-reviews] review granted: [Bug 216069] Store all styling flags in m_rendererWithStyleFlags : [Attachment 407841] Updated per review comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 216069: Store all styling flags in m_rendererWithStyleFlags
https://bugs.webkit.org/show_bug.cgi?id=216069

Attachment 407841: Updated per review comments

https://bugs.webkit.org/attachment.cgi?id=407841&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 407841
  --> https://bugs.webkit.org/attachment.cgi?id=407841
Updated per review comments

View in context: https://bugs.webkit.org/attachment.cgi?id=407841&action=review

> Source/WebCore/dom/Node.h:605
> +	   uint16_t toRaw() { return bitwise_cast<uint16_t>(*this); }

const

> Source/WebCore/dom/Node.h:622
> +	   uint8_t m_styleValidity : 2;
> +	   uint8_t m_dynamicStyleRelation : 6;
> +	   uint8_t m_flags : 8;

Why is uint8_t better for this than unsigned? I ask in part because the style
script checks and complains.