[webkit-reviews] review granted: [Bug 216105] Add an STP callout to Web Inspector documentation : [Attachment 407825] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 2 16:01:59 PDT 2020
Devin Rousso <drousso at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 216105: Add an STP callout to Web Inspector documentation
https://bugs.webkit.org/show_bug.cgi?id=216105
Attachment 407825: Patch
https://bugs.webkit.org/attachment.cgi?id=407825&action=review
--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 407825
--> https://bugs.webkit.org/attachment.cgi?id=407825
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=407825&action=review
r=me
> Websites/webkit.org/wp-content/themes/webkit/single-web_inspector_page.php:20
> + Updated for <a
href="https://developer.apple.com/safari/technology-preview/">Safari Technology
Preview</a><?php echo empty($revision)?'':" $revision"; ?>. Try it out for the
latest Web Inspector features, including all of the above and more.</p>
NIT: do you want to add spaces around the ternary (e.g. `empty($revision) ? ''
: " $revision" ;`)?
More information about the webkit-reviews
mailing list