[webkit-reviews] review granted: [Bug 216005] [macOS] Add disabled and readonly behaviors to date inputs : [Attachment 407686] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 216005: [macOS] Add disabled and readonly behaviors to date inputs
https://bugs.webkit.org/show_bug.cgi?id=216005

Attachment 407686: Patch

https://bugs.webkit.org/attachment.cgi?id=407686&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 407686
  --> https://bugs.webkit.org/attachment.cgi?id=407686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407686&action=review

r=me, nice works!

> Source/WebCore/css/html.css:520
> +input[disabled]::-webkit-datetime-edit-year-field,

NIT: should these be `input[type="date"]`?

> Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp:318
> +    return element()->isDisabledFormControl();

NIT: should this have `ASSERT(element())` too?

> Source/WebCore/html/shadow/DateTimeFieldElement.cpp:119
> +bool DateTimeFieldElement::isFocusable() const

(for my own knowledge) is this what's used to determine whether or not the
`<input type="date">` is mouse-interactable?  I ask because `disabled` should
prevent all interaction but `readonly` should still allow mouse interaction.