[webkit-reviews] review granted: [Bug 216098] Use unicode macros instead of manual range checks in TextCodecUTF16 : [Attachment 407813] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 2 14:22:16 PDT 2020


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 216098: Use unicode macros instead of manual range checks in TextCodecUTF16
https://bugs.webkit.org/show_bug.cgi?id=216098

Attachment 407813: Patch

https://bugs.webkit.org/attachment.cgi?id=407813&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 407813
  --> https://bugs.webkit.org/attachment.cgi?id=407813
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407813&action=review

> Source/WebCore/platform/text/TextCodecSingleByte.cpp:2
> + * Copyright (C) 2020 Apple Inc. All rights reserved.

I assume you didn’t mean to include this in this patch.

> Source/WebCore/platform/text/TextCodecSingleByte.h:32
> +class TextCodecSingleByte : public TextCodec {

I assume you didn’t mean to include this in this patch.


More information about the webkit-reviews mailing list