[webkit-reviews] review granted: [Bug 210197] REGRESSION (r251254): Web Inspector: Text insertion point is invisible when editing DOM nodes : [Attachment 407788] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 210197: REGRESSION (r251254): Web Inspector: Text insertion point is
invisible when editing DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=210197

Attachment 407788: Patch

https://bugs.webkit.org/attachment.cgi?id=407788&action=review




--- Comment #12 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 407788
  --> https://bugs.webkit.org/attachment.cgi?id=407788
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407788&action=review

r=me

Please make a new bug for fixing the non-solid issue that's blocked by bug
213501.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:47
> +    --shadow-background-color: hsla(0, 0%, 0%, 0.05);

this could use a better name, like `--shadow-subtree-background-color`

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:-77
> -.tree-outline.dom li > :not(.selection-area) {

(note for the future) we probably only need to do this when inside a `.shadow`