[webkit-reviews] review granted: [Bug 216082] AbstractMacroAssembler::Jump class has uninitialized instance variables : [Attachment 407778] Patch v1

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 216082: AbstractMacroAssembler::Jump class has uninitialized instance
variables
https://bugs.webkit.org/show_bug.cgi?id=216082

Attachment 407778: Patch v1

https://bugs.webkit.org/attachment.cgi?id=407778&action=review




--- Comment #3 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 407778
  --> https://bugs.webkit.org/attachment.cgi?id=407778
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=407778&action=review

r=me.  This is good defensive programming, but I don't think that this fixes
any latent bugs as these fields are set for the instruction variants that use
them.

>> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:685
>> +	    bool m_is64Bit { false };
> 
> Should this be { true } instead since this is only compiled on CPU(ARM64)? 
Or do we have 32-bit jumps in arm64[e]?

All jumps for ARM64[e] are 64 bit in terms of changes to the PC.  The m_is64Bit
is for the compare and branch jumps (CBZ and CBNZ) and relate to the size of
the comparison.  The m_is64Bit flag is not used for the other branch types.