[webkit-reviews] review granted: [Bug 216068] [GLIB] kill-old-processes: Remove stale Apache2 shm segments : [Attachment 407744] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 2 10:31:14 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 216068: [GLIB] kill-old-processes: Remove stale Apache2 shm segments
https://bugs.webkit.org/show_bug.cgi?id=216068

Attachment 407744: Patch

https://bugs.webkit.org/attachment.cgi?id=407744&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 407744
  --> https://bugs.webkit.org/attachment.cgi?id=407744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407744&action=review

> Tools/BuildSlaveSupport/kill-old-processes:27
> +import subprocess as sp

Why rename the module? WebKit coding style is to avoid abbreviations.


More information about the webkit-reviews mailing list