[webkit-reviews] review granted: [Bug 215410] [LFC][IFC] Finalize InlineBox alignment in LineBox : [Attachment 407618] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 215410: [LFC][IFC] Finalize InlineBox alignment in LineBox
https://bugs.webkit.org/show_bug.cgi?id=215410

Attachment 407618: Patch

https://bugs.webkit.org/attachment.cgi?id=407618&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 407618
  --> https://bugs.webkit.org/attachment.cgi?id=407618
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407618&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:514
> -    // Compute box final geometry.
> +    // Compute final box geometry.

Solid progression.

> Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:191
> +    auto lineIsConsideredEmpty = !lineHasImaginaryStrut ||
isLineVisuallyEmpty == IsLineVisuallyEmpty::Yes ?
InlineBox::IsConsideredEmpty::Yes : InlineBox::IsConsideredEmpty::No;

For this sort of things bools would read better.