[webkit-reviews] review granted: [Bug 215835] REGRESSION (r264661): Crashes in WebCore::wrap<WebCore::Blob> in CloneDeserializer : [Attachment 407721] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 2 02:38:21 PDT 2020


youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 215835: REGRESSION (r264661): Crashes in WebCore::wrap<WebCore::Blob> in
CloneDeserializer
https://bugs.webkit.org/show_bug.cgi?id=215835

Attachment 407721: Patch

https://bugs.webkit.org/attachment.cgi?id=407721&action=review




--- Comment #13 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 407721
  --> https://bugs.webkit.org/attachment.cgi?id=407721
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407721&action=review

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:2042
> +	   , m_isValidDOMGlobalObject(m_isDOMGlobalObject &&
!globalObject->inherits<JSIDBSerializationGlobalObject>(globalObject->vm()))

I would rename it to something like m_canCreateDOMObject.


More information about the webkit-reviews mailing list