[webkit-reviews] review granted: [Bug 202065] REGRESSION(r243264): Web Inspector: Style pane doesn't update after toggling CSS class : [Attachment 407715] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 202065: REGRESSION(r243264): Web Inspector: Style pane doesn't update after
toggling CSS class
https://bugs.webkit.org/show_bug.cgi?id=202065

Attachment 407715: Patch

https://bugs.webkit.org/attachment.cgi?id=407715&action=review




--- Comment #32 from Brian Burg <bburg at apple.com> ---
Comment on attachment 407715
  --> https://bugs.webkit.org/attachment.cgi?id=407715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407715&action=review

r=me, great work!

> LayoutTests/ChangeLog:9
> +	   Added a test to veryfy that WI.DOMNodeStyles.Event.Refreshed fires
with appropriate

Nit: verify

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
47
> +	   this._ignoreLayoutAfterSelectorChange = false;

Nit: please rename. We typically name this 'suppress' if it's stopping
something from happening. i.e., this._suppressLayoutAfterSelectorChange.