[webkit-reviews] review granted: [Bug 216006] Introduce a C++ chain of operations in RTCPeerConnection : [Attachment 407612] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 216006: Introduce a C++ chain of operations in RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=216006

Attachment 407612: Patch

https://bugs.webkit.org/attachment.cgi?id=407612&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 407612
  --> https://bugs.webkit.org/attachment.cgi?id=407612
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407612&action=review

>
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteD
escription-offer-expected.txt:2
> -Harness Error (FAIL), message = Unhandled rejection: Description type
incompatible with current signaling state
> +Harness Error (TIMEOUT), message = null

Why do we timeout now?

>
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https-expe
cted.txt:32
> +FAIL checkStopAfterCreateOffer assert_equals: expected
"[{mid:null,stopped:true}]" but got "[{mid:\"0\",stopped:true}]"
> +FAIL checkStopAfterSetLocalOffer assert_equals: expected
"[{mid:null,stopped:true}]" but got "[{mid:\"0\",stopped:true}]"
> +FAIL checkStopAfterSetRemoteOffer assert_equals: expected "[]" but got
"[{isTrusted:true}]"
> +FAIL checkStopAfterCreateAnswer assert_equals: expected
"[{mid:null,stopped:true}]" but got "[{mid:\"0\",stopped:true}]"

Looks like this only fails because we return `0` instead of `null`. Can we fix
this?

>
LayoutTests/platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.
txt:4
> -PASS captureStream with webrtc - h264 baseline 
> -PASS captureStream with webrtc - h264 high profile 
> +FAIL captureStream with webrtc - h264 baseline promise_test: Unhandled
rejection with value: "test2 failed"
> +FAIL captureStream with webrtc - h264 high profile promise_test: Unhandled
rejection with value: "test2 failed"

Is this expected?