[webkit-reviews] review granted: [Bug 216043] Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled : [Attachment 407692] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 1 10:46:20 PDT 2020
Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 216043: Skip
fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if
Gigacage is not enabled
https://bugs.webkit.org/show_bug.cgi?id=216043
Attachment 407692: Patch
https://bugs.webkit.org/attachment.cgi?id=407692&action=review
--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 407692
--> https://bugs.webkit.org/attachment.cgi?id=407692
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review
r=me with fix
> Source/JavaScriptCore/tools/JSDollarVM.cpp:3124
> + return JSValue::encode(jsBoolean(Gigacage::isEnabled()));
Can you add `DollarVMAssertScope assertScope;` before this line?
More information about the webkit-reviews
mailing list