[webkit-reviews] review granted: [Bug 216031] EventRegion paint should respect layer's foreground and background painting phases : [Attachment 407668] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 216031: EventRegion paint should respect layer's foreground and background
painting phases
https://bugs.webkit.org/show_bug.cgi?id=216031

Attachment 407668: patch

https://bugs.webkit.org/attachment.cgi?id=407668&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 407668
  --> https://bugs.webkit.org/attachment.cgi?id=407668
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407668&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1140
> +	   if (paintInfo.eventRegionContext)
> +	      
paintInfoForChild.paintBehavior.add(PaintBehavior::EventRegionIncludeBackground
);

This is pretty weird. I wish event region painting followed normal painting
more closely.

> Source/WebCore/rendering/RenderLayer.cpp:4654
> +	       paintBehavior = paintBehavior &
PaintBehavior::CompositedOverflowScrollContent;

I know you moved this and I added it in r262337 but I don't understand it.