[webkit-reviews] review denied: [Bug 218381] [WTF] Coding style issues in MediaTime.h : [Attachment 412731] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 21:03:10 PDT 2020

Yusuke Suzuki <ysuzuki at apple.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 218381: [WTF] Coding style issues in MediaTime.h

Attachment 412731: Patch


--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 412731
  --> https://bugs.webkit.org/attachment.cgi?id=412731

I think these functions are small and should be inline function. So defining in
the header is better. Let's remove WTF_EXPORT_PRIVATE from the class, and
annotate some of actually exported functions with WTF_EXPORT_PRIVATE.

More information about the webkit-reviews mailing list