[webkit-reviews] review granted: [Bug 218378] Further lessen reliance on VPATH in WebCore/DerivedSources.make : [Attachment 412725] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 12:26:13 PDT 2020

Darin Adler <darin at apple.com> has granted Keith Rollin <krollin at apple.com>'s
request for review:
Bug 218378: Further lessen reliance on VPATH in WebCore/DerivedSources.make

Attachment 412725: Patch


--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 412725
  --> https://bugs.webkit.org/attachment.cgi?id=412725

View in context: https://bugs.webkit.org/attachment.cgi?id=412725&action=review

> Source/WebCore/DerivedSources.make:1315
> +    $(sort \
> +	   $(foreach \

I think putting sort and foreach on separate lines is perhaps overdoing it a
bit. I’m OK with this sort of vertical formatting if it makes things clearer
but I’m not sure it’s having that effect here, and especially not for the sort
line vs. the foreach lines.

It might be hard to see the structure in one super-long line, but we should
explore other ways to do that. I think this one might be *easier* to read as
one line.

More information about the webkit-reviews mailing list