[webkit-reviews] review granted: [Bug 217506] [Cocoa] [GPU Process] Perform image decoding of color fonts in the Web Process : [Attachment 412757] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 217506: [Cocoa] [GPU Process] Perform image decoding of color fonts in the
Web Process
https://bugs.webkit.org/show_bug.cgi?id=217506

Attachment 412757: Patch

https://bugs.webkit.org/attachment.cgi?id=412757&action=review




--- Comment #36 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 412757
  --> https://bugs.webkit.org/attachment.cgi?id=412757
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412757&action=review

> Source/WebCore/ChangeLog:14
> +	   character, Core Text will end up telling Core Graphics to draw all
the outlines, and then telling Core
> +	   Graphics to draw the emoji image (using Core Graphics's normal image
drawing routines).

This makes it sound like the emoji are z-ordered on top but I don't think they
are.

>
Source/WebCore/platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCore
Text.cpp:106
> +    m_originalState.ctm = m_owner.currentState().ctm; // FIXME: Deal with
device scale.

How important is this FIXME?

>
Source/WebCore/platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCore
Text.cpp:309
> +    // We want the GPU process's CTM and text matrix to match the current
CTM and text matrix.

This code shouldn't reference the GPU process.