[webkit-reviews] review granted: [Bug 218374] Convert ScrollingTreeNode change flags to an OptionSet<> : [Attachment 412715] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 29 22:37:02 PDT 2020
Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 218374: Convert ScrollingTreeNode change flags to an OptionSet<>
https://bugs.webkit.org/show_bug.cgi?id=218374
Attachment 412715: Patch
https://bugs.webkit.org/attachment.cgi?id=412715&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 412715
--> https://bugs.webkit.org/attachment.cgi?id=412715
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412715&action=review
>
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
110
> +template<> struct EnumTraits<WebCore::ScrollingStateNode::Property> {
> + using values = EnumValues<
> + WebCore::ScrollingStateNode::Property,
> + WebCore::ScrollingStateNode::Property::Layer,
> + WebCore::ScrollingStateNode::Property::ChildNodes,
> + WebCore::ScrollingStateNode::Property::ScrollableAreaSize,
Sad that this thing has to list all values again. Does it at least fail at
compile time if you miss something?
More information about the webkit-reviews
mailing list