[webkit-reviews] review granted: [Bug 218355] Remove all remaining boolean overridePreference calls : [Attachment 412695] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 29 15:46:34 PDT 2020


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 218355: Remove all remaining boolean overridePreference calls
https://bugs.webkit.org/show_bug.cgi?id=218355

Attachment 412695: Patch

https://bugs.webkit.org/attachment.cgi?id=412695&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 412695
  --> https://bugs.webkit.org/attachment.cgi?id=412695
Patch

A lot of unneeded "window." prefixes in these tests. Once we know we’re running
in a test runner, then "internals" works, and we don’t need "window.internals".


More information about the webkit-reviews mailing list