[webkit-reviews] review granted: [Bug 218097] [macOS] Set preference for overridden languages in the WebContent process after entering the sandbox. : [Attachment 412684] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 218097: [macOS] Set preference for overridden languages in the WebContent
process after entering the sandbox.
https://bugs.webkit.org/show_bug.cgi?id=218097

Attachment 412684: Patch

https://bugs.webkit.org/attachment.cgi?id=412684&action=review




--- Comment #22 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 412684
  --> https://bugs.webkit.org/attachment.cgi?id=412684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412684&action=review

Thank you for testing! It would be useful to check the full scenario with
localizations in the API test. But it doesn't have to be part of this patch to
test something that's preexisting behavior.

> LayoutTests/ChangeLog:8
> +	   Add test for sandbox access to cfprefsd.daemon, and mark cfprefsd
tests as failing for Mojave, since CFPrefs

This is surprising. CFPREFS_DIRECT_MODE is not enabled on Catalina either, so
doesn't the failing result need to be in platform/mac-catalina?