[webkit-reviews] review canceled: [Bug 218228] [MSE] Infinite loop in sample eviction when duration is NaN : [Attachment 412646] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has canceled Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 218228: [MSE] Infinite loop in sample eviction when duration is NaN
https://bugs.webkit.org/show_bug.cgi?id=218228

Attachment 412646: Patch

https://bugs.webkit.org/attachment.cgi?id=412646&action=review




--- Comment #13 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 412646
  --> https://bugs.webkit.org/attachment.cgi?id=412646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412646&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1000
> +    if (rangeEnd.isInvalid() || rangeEnd.isIndefinite()) {
> +	   rangeEnd = buffered.maximumBufferedTime();

I'm not sure this covers all the possible cases; it sounds like MediaTime needs
an "isFinite()" that returns false for invalid, indefinite, and infinite
values.  (The Cocoa ports, for example, treat "Indefinite" differently than
"Positive Infinite")