[webkit-reviews] review granted: [Bug 209729] [WPE] Add axis-locking to kinetic scrolling : [Attachment 412655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 29 09:20:55 PDT 2020


Adrian Perez <aperez at igalia.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 209729: [WPE] Add axis-locking to kinetic scrolling
https://bugs.webkit.org/show_bug.cgi?id=209729

Attachment 412655: Patch

https://bugs.webkit.org/attachment.cgi?id=412655&action=review




--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 412655
  --> https://bugs.webkit.org/attachment.cgi?id=412655
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412655&action=review

> Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp:62
> +		   || deltaTime >= scrollCaptureThreshold;

Much nicer to have this as a symbolic constant instead of a magic number ��️


More information about the webkit-reviews mailing list