[webkit-reviews] review requested: [Bug 218295] Web Inspector: Extra closing parenthesis added after var in styles panel : [Attachment 412596] WIP

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 17:58:52 PDT 2020


Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 218295: Web Inspector: Extra closing parenthesis added after var in styles
panel
https://bugs.webkit.org/show_bug.cgi?id=218295

Attachment 412596: WIP

https://bugs.webkit.org/attachment.cgi?id=412596&action=review




--- Comment #4 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 412596

  --> https://bugs.webkit.org/attachment.cgi?id=412596&action=review

WIP

This fixes the bug. However, this method is pretty error prone and could really
benefit from unit tests. I'm planning to move it outside of the Views.


More information about the webkit-reviews mailing list