[webkit-reviews] review granted: [Bug 218291] [Testing] Remove requirement of adding new SPI for each preference that needs testing (WebKitLegacy Windows) : [Attachment 412559] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 15:42:51 PDT 2020


Brent Fulgham <bfulgham at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 218291: [Testing] Remove requirement of adding new SPI for each preference
that needs testing (WebKitLegacy Windows)
https://bugs.webkit.org/show_bug.cgi?id=218291

Attachment 412559: Patch

https://bugs.webkit.org/attachment.cgi?id=412559&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 412559
  --> https://bugs.webkit.org/attachment.cgi?id=412559
Patch

r=me. The Windows build failure is not because of this change, but is a symptom
of a dependency problem in the IDL generation on Windows. We may need to force
a clean build once this lands.


More information about the webkit-reviews mailing list