[webkit-reviews] review granted: [Bug 218133] [GTK] Smooth scrolling should not apply to continuous scrolling with sync scrolling : [Attachment 412534] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 218133: [GTK] Smooth scrolling should not apply to continuous scrolling
with sync scrolling
https://bugs.webkit.org/show_bug.cgi?id=218133

Attachment 412534: Patch

https://bugs.webkit.org/attachment.cgi?id=412534&action=review




--- Comment #23 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 412534
  --> https://bugs.webkit.org/attachment.cgi?id=412534
Patch

Logic LGTM. Take a look at the comments below before landing to
avoid breaking the GTK4 build.

View in context: https://bugs.webkit.org/attachment.cgi?id=412534&action=review

> Source/WebCore/platform/PlatformWheelEvent.h:-144
> -#if PLATFORM(COCOA) || PLATFORM(GTK) || USE(LIBWPE)

Nice to see conditional compilation guards go away \o/

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:74
> +	       if (auto* device =
gdk_event_get_source_device(reinterpret_cast<GdkEvent*>(event)))

This function is gone in GTK4, so this will break builds configured with
USE_GTK4=ON. The function is now gdk_event_get_device() and does exactly
the same, so we can add in Source/WebCore/platform/gtk/GtkVersioning.h a
definition of gdk_event_get_device() which when building for GTK3 calls
gdk_event_get_source_device() — there are other similar functions already
in that header ��️

> Source/WebKit/Shared/gtk/WebEventFactory.cpp:288
> +	       if (auto* device = gdk_event_get_source_device(event))

Same here :)